Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customizable alphabet using OcrEngineParams #100

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

Phaired
Copy link
Contributor

@Phaired Phaired commented Aug 22, 2024

I made this I don't now if it's good enough to be merged, it just add a parameter with the same default value as before.

Copy link
Owner

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. Thanks for this. The API looks good. Some comments and whitespace went missing in this diff, can you reinstate them. Also there are a few comments that can be omitted because the code is clear enough on its own.

ocrs/src/lib.rs Outdated Show resolved Hide resolved
ocrs/src/lib.rs Outdated Show resolved Hide resolved
ocrs/src/recognition.rs Outdated Show resolved Hide resolved
ocrs/src/recognition.rs Outdated Show resolved Hide resolved
ocrs/src/lib.rs Show resolved Hide resolved
ocrs-cli/src/main.rs Show resolved Hide resolved
@Phaired
Copy link
Contributor Author

Phaired commented Aug 26, 2024

I made modifications based on your comment. Please let me know if it's good for you

@robertknight
Copy link
Owner

Sorry for the delay. The changes look good. I'll get them merged soon.

@robertknight robertknight merged commit faca741 into robertknight:main Aug 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants