Make mittens deterministic #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 20, 2023 14:01
- Previously, randmatrix() calls np.random.seed every time. This makes it impossible to reproduce mittens runs. - Now a global random number generator is instantiated via np.random.default_rng.
- Previously, randmatrix() calls np.random.seed every time. This makes it impossible to reproduce mittens runs. - Now a global random number generator is instantiated via np.random.default_rng.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, randmatrix() calls np.random.seed every time. This
makes it impossible to reproduce mittens runs.
Now a global random number generator is instantiated via
np.random.default_rng.
I have not changed any interface functions and the change should be backwards compatible. A user can set the seed either by assigning a random number generator to the global variable
randomor assigning a seed to the global variableseed.