Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #385

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Drop support for Python 3.7 #385

merged 7 commits into from
Oct 19, 2023

Conversation

thijstriemstra
Copy link
Collaborator

@thijstriemstra thijstriemstra commented Oct 18, 2023

also:

  • update test data for Pillow 10.1.0
  • doc: use virtual environment for installation

fixes #384

@thijstriemstra thijstriemstra marked this pull request as ready for review October 18, 2023 13:30
@thijstriemstra
Copy link
Collaborator Author

thijstriemstra commented Oct 18, 2023

Default font config for Pillow changed in 10.1.0, causing our tests to fail (because it uses a different "builtin" font AFAIK). See https://pillow.readthedocs.io/en/latest/releasenotes/10.1.0.html#size-and-font-size-arguments-when-using-default-font

Will have to regenerate the test data to fix it (hopefully).

@thijstriemstra
Copy link
Collaborator Author

The Python 3.7 builder fails because the newest Pillow generates different data and since Python 3.7 is stuck with Pillow <= 9.5.0 I suggest we removed Python 3.7 support since it also reached end of life 4 months ago.

@thijstriemstra thijstriemstra changed the title doc: use virtual environment for installation Drop support for Python 3.7 Oct 18, 2023
@thijstriemstra
Copy link
Collaborator Author

@rm-hull can you force merge it, py3.7 builder is acting up

@rm-hull rm-hull merged commit 0a89c5f into master Oct 19, 2023
8 checks passed
@rm-hull rm-hull deleted the doc-venv branch October 19, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'sh1107' from 'luma.oled.device'
2 participants