Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes middlewares pluggable. i.e for custom oauth flows or analytics etc. #395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fredr
Copy link

@fredr fredr commented Apr 14, 2016

I'm building a github web oauth authorization plugin for sinopia. To achieve that in a good way I need to be able to register custom routes in sinopia, so that I don't have to have github or sinopia secrets on my client to be able to generate a .npmrc

@rbecheras
Copy link

👍 💯 ;-)

A github web oauth authorization plugin for sinopia ?

Awesome !

Even better, what about a provider-agnostic web oauth authorization plugin for sinopia ?

And then, on top of this, you could build a github adapter for this plugin, and any else would be able to build adapters for other providers (like gitlab for example), or private ones (for private Oauth2 servers).

Personally, if it would exist, I will use all of these in my organisation. I think I'm not the only one person that could benefit of a such capabilities.

@rbecheras
Copy link

@fredr , could you please post a link to the github repo of your plugin project (if exists) ?

@dgaya
Copy link

dgaya commented Apr 15, 2016

Neat !!
I'm afraid this repo is no longer supported.

Do you mind PR to our clone https://github.com/fl4re/sinopia ?
I already have a google and github oauth2 login in our branch OAuth_login.
But your solution is neat, I will use it.

@fredr
Copy link
Author

fredr commented Apr 15, 2016

@rbecheras sure, this would enable anyone to write such plugins. Im building this one: https://github.com/soundtrackyourbrand/sinopia-github-oauth
Its a bit work in progress, but first version should be done today, or soon enough.

@dgaya I know, but I thought I'd add a PR anyway. Cool, your fork seems to be more active! I'll open a PR there!

@JDvorak
Copy link

JDvorak commented Apr 27, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants