Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added STEAMWORKS_NET define #484

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Added STEAMWORKS_NET define #484

merged 1 commit into from
Feb 6, 2022

Conversation

rlabrecque
Copy link
Owner

@rlabrecque rlabrecque closed this Feb 6, 2022
@rlabrecque rlabrecque reopened this Feb 6, 2022
@rlabrecque rlabrecque merged commit 69a81da into master Feb 6, 2022
@rlabrecque rlabrecque deleted the add-steamworks-define branch February 6, 2022 21:23
@JamesMcGhee
Copy link
Contributor

Ewww you use that Java style K&R formating 🤢 barbarian 🤣

Jokes aside happy days we have a script define now that other assets can use to detect install ... I will let the groups I work with know its present going forward.

@rlabrecque
Copy link
Owner Author

I don't actually prefer it anymore; especially because that's not the default for C# in VS IIRC, but -- switching should be a change on it's own and it's rather pointless especially if it creates merge conflicts with forks

@StumpyBear
Copy link

As a developer on a project that also builds for many non steam platforms I prefer the opt in approach on the defines rather than it being defined for me and I have to undefine it in a build step when building for xbox ect

@JamesMcGhee
Copy link
Contributor

JamesMcGhee commented Mar 3, 2022

Shouldn't ever be undefining this one ... it only lets other code know this code exists in the project so its not taking over for DISABLESTEAMWORKS or anything

Also as for platform compilation the assembly defs do that for you as well ... they wouldn't compile for XBox anyway so no need to use script defines to strip them

If Unity ever gets off its backside regarding Package Manager then PackageManager.Client.List would let us programatically check what Package Manager packages where installed and check there version ... so a much better system ... but that isn't really here just yet

and it doesn't account for manually installed code

That said I can give a think on a better solution, this method is the method used by any asset I have seen thus far but if something is better its better ... I'll ahve a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants