feat: self-hosting docs #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ABCxFF
commented
May 29, 2024
ABCxFF
commented
- Allow support for external postgres
- Fix relative paths in opengb build
NathanFlurry
requested changes
May 29, 2024
| @@ -1,5 +1,9 @@ | |||
| const DEFAULT_DATABASE_URL = "postgres://postgres:postgres@localhost:5432/postgres?sslmode=disable"; | |||
|
|
|||
| export function isExternalDatabase(): boolean { | |||
| return typeof Deno.env.get("DATABASE_URL") === "string"; | |||
| @@ -13,11 +14,15 @@ const POSTGRES_ONCE = createOnce<void>(); | |||
| */ | |||
| export async function ensurePostgresRunning(project: Project) { | |||
| return await getOrInitOnce(POSTGRES_ONCE, async () => { | |||
| await ensurePostgresRunningInner(project); | |||
| if (isExternalDatabase()) { | |||
There was a problem hiding this comment.
move outside of await, it's faster
| @@ -1,5 +1,9 @@ | |||
| const DEFAULT_DATABASE_URL = "postgres://postgres:postgres@localhost:5432/postgres?sslmode=disable"; | |||
|
|
|||
| export function isExternalDatabase(): boolean { | |||
There was a problem hiding this comment.
add brief docs on what this represents and how external db works
ABCxFF
force-pushed
the
05-22-fix-build-disable-psql-check-when-unneeded
branch
from
c38096b
to
47c7bd3
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
NathanFlurry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.