Skip to content

Commit

Permalink
Require double confirmation for deleting all transactions
Browse files Browse the repository at this point in the history
The user must check a checkbox to enable the delete button. This tries
to avoid confirming irreversible actions by mistake.

Fixes codinguser#544
  • Loading branch information
rivaldi8 committed Sep 3, 2017
1 parent 8b78d1c commit add808a
Showing 1 changed file with 3 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,11 @@
*/
package org.gnucash.android.ui.settings.dialog;

import android.app.AlertDialog;
import android.app.Dialog;
import android.content.Context;
import android.content.DialogInterface;
import android.os.Bundle;
import android.support.annotation.NonNull;
import android.support.v4.app.DialogFragment;
import android.util.Log;
import android.widget.Toast;

Expand All @@ -44,7 +42,7 @@
* @author ngewif <ngewif@gmail.com>
* @author Yongxin Wang <fefe.wyx@gmail.com>
*/
public class DeleteAllTransactionsConfirmationDialog extends DialogFragment {
public class DeleteAllTransactionsConfirmationDialog extends DoubleConfirmationDialog {

public static DeleteAllTransactionsConfirmationDialog newInstance() {
DeleteAllTransactionsConfirmationDialog frag = new DeleteAllTransactionsConfirmationDialog();
Expand All @@ -53,7 +51,7 @@ public static DeleteAllTransactionsConfirmationDialog newInstance() {

@Override
@NonNull public Dialog onCreateDialog(Bundle savedInstanceState) {
return new AlertDialog.Builder(getActivity())
return getDialogBuilder()
.setIcon(android.R.drawable.ic_delete)
.setTitle(R.string.title_confirm_delete).setMessage(R.string.msg_delete_all_transactions_confirmation)
.setPositiveButton(R.string.alert_dialog_ok_delete,
Expand All @@ -80,19 +78,6 @@ public void onClick(DialogInterface dialog, int whichButton) {
}
}

)
.

setNegativeButton(R.string.alert_dialog_cancel,
new DialogInterface.OnClickListener() {
public void onClick(DialogInterface dialog, int whichButton) {
dismiss();
}
}

)
.

create();
).create();
}
}

0 comments on commit add808a

Please sign in to comment.