-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sqlsmith): updates and deletes #9985
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9985 +/- ##
==========================================
- Coverage 71.09% 71.09% -0.01%
==========================================
Files 1230 1230
Lines 210331 210334 +3
==========================================
Hits 149536 149536
- Misses 60795 60798 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -1,59 +0,0 @@ | |||
// Copyright 2023 RisingWave Labs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to dml.rs
@@ -0,0 +1,233 @@ | |||
// Copyright 2023 RisingWave Labs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This contains the update and delete generation logic.
2760064
to
64d233b
Compare
New commits are solely from rebasing. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Around ~500 lines are from the snapshot tests.
Sqlsmith currently does the following:
After this PR:
I found that interleaving inserts, updates and deletes between stream queries is complicated to debug. I have left it out for now. It can be done in the future.
Updates and deletes are generated by:
Closes #9824.
Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note