feat(connector-node): docker build connector node using local source code #8414
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8414 +/- ##
==========================================
- Coverage 71.58% 71.57% -0.01%
==========================================
Files 1135 1135
Lines 185113 185113
==========================================
- Hits 132515 132501 -14
- Misses 52598 52612 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -33,14 +33,14 @@ RUN rustup self update \ | |||
| && rustup component add rustfmt | |||
|
|
|||
| RUN cargo fetch | |||
| RUN mkdir -p /risingwave/bin/connector-node | |||
There was a problem hiding this comment.
need keep here, because it will use in this command: mv /risingwave/target/release/risingwave /risingwave/bin/
| RUN cd risingwave-connector-node && mvn -B package -Dmaven.test.skip=true | ||
| RUN tar -zxvf /risingwave/risingwave-connector-node/assembly/target/risingwave-connector-1.0.0.tar.gz -C /risingwave/bin/connector-node | ||
| RUN cd /risingwave/java && mvn -B package -Dmaven.test.skip=true && \ | ||
| mkdir -p /risingwave/bin/connector-node && \ |
There was a problem hiding this comment.
maybe should delete here.
There was a problem hiding this comment.
This is in the builder, so I think the tar file will not be included in the final image
|
I have tried triggering a pipeline to build the docker image. I works fine. https://buildkite.com/risingwavelabs/docker/builds/13440#0186c0f6-bbe5-446d-9092-310c439d1c91 |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As titled. Previously we build the docker image from the source clone from the original connector-node repo. In this PR, we change to build connector node from the local connector source code.
Checklist For Contributors
./risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note