Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(temporal-join): Temporal join executor #8412

Merged
merged 5 commits into from
Mar 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/stream/src/executor/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ mod sort_buffer;
pub mod source;
mod stream_reader;
pub mod subtask;
mod temporal_join;
mod top_n;
mod union;
mod watermark;
Expand Down
287 changes: 287 additions & 0 deletions src/stream/src/executor/temporal_join.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,287 @@
// Copyright 2023 RisingWave Labs
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

use std::alloc::Global;
use std::sync::Arc;

use either::Either;
use futures::stream::{self, PollNext};
use futures::{StreamExt, TryStreamExt};
use futures_async_stream::try_stream;
use local_stats_alloc::{SharedStatsAlloc, StatsAlloc};
use lru::DefaultHasher;
use risingwave_common::array::{Op, StreamChunk};
use risingwave_common::catalog::Schema;
use risingwave_common::row::{OwnedRow, Row, RowExt};
use risingwave_common::util::iter_util::ZipEqFast;
use risingwave_hummock_sdk::{HummockEpoch, HummockReadEpoch};
use risingwave_storage::table::batch_table::storage_table::StorageTable;
use risingwave_storage::StateStore;

use super::{Barrier, Executor, Message, MessageStream, StreamExecutorError, StreamExecutorResult};
use crate::cache::{new_with_hasher_in, ManagedLruCache};
use crate::common::StreamChunkBuilder;
use crate::executor::monitor::StreamingMetrics;
use crate::executor::{ActorContextRef, BoxedExecutor, JoinType, JoinTypePrimitive, PkIndices};
use crate::task::AtomicU64Ref;

pub struct TemporalJoinExecutor<S: StateStore, const T: JoinTypePrimitive> {
// TODO: update metrics
#[allow(dead_code)]
ctx: ActorContextRef,
left: BoxedExecutor,
right: BoxedExecutor,
right_table: TemporalSide<S>,
left_join_keys: Vec<usize>,
right_join_keys: Vec<usize>,
null_safe: Vec<bool>,
output_indices: Vec<usize>,
pk_indices: PkIndices,
schema: Schema,
chunk_size: usize,
identity: String,
// TODO: update metrics
#[allow(dead_code)]
metrics: Arc<StreamingMetrics>,
}

struct TemporalSide<S: StateStore> {
source: StorageTable<S>,
cache: ManagedLruCache<OwnedRow, Option<OwnedRow>, DefaultHasher, SharedStatsAlloc<Global>>,
}

impl<S: StateStore> TemporalSide<S> {
async fn lookup(
&mut self,
key: impl Row,
epoch: HummockEpoch,
) -> StreamExecutorResult<Option<OwnedRow>> {
let key = key.into_owned_row();
Ok(match self.cache.get(&key) {
Some(res) => res.clone(),
None => {
let res = self
.source
.get_row(key.clone(), HummockReadEpoch::NoWait(epoch))
.await?;
self.cache.put(key, res.clone());
res
}
})
}

fn update(&mut self, payload: Vec<StreamChunk>, join_keys: &[usize], epoch: u64) {
payload.iter().flat_map(|c| c.rows()).for_each(|(op, row)| {
let key = row.project(join_keys).into_owned_row();
if let Some(value) = self.cache.get_mut(&key) {
match op {
Op::Insert | Op::UpdateInsert => *value = Some(row.into_owned_row()),
Op::Delete | Op::UpdateDelete => *value = None,
};
}
});
self.cache.update_epoch(epoch);
}
}

enum InternalMessage {
Chunk(StreamChunk),
Barrier(Vec<StreamChunk>, Barrier),
}

#[try_stream(ok = StreamChunk, error = StreamExecutorError)]
pub async fn chunks_until_barrier(stream: impl MessageStream, expected_barrier: Barrier) {
#[for_await]
for item in stream {
match item? {
Message::Watermark(_) => {
todo!("https://github.com/risingwavelabs/risingwave/issues/6042")
}
Message::Chunk(c) => yield c,
Message::Barrier(b) if b.epoch != expected_barrier.epoch => {
return Err(StreamExecutorError::align_barrier(expected_barrier, b));
}
Message::Barrier(_) => return Ok(()),
}
}
}

// Align the left and right inputs according to their barriers,
// such that in the produced stream, an aligned interval starts with
// any number of `InternalMessage::Chunk(left_chunk)` and followed by
// `InternalMessage::Barrier(right_chunks, barrier)`.
#[try_stream(ok = InternalMessage, error = StreamExecutorError)]
async fn align_input(left: Box<dyn Executor>, right: Box<dyn Executor>) {
let mut left = Box::pin(left.execute());
let mut right = Box::pin(right.execute());
// Keep producing intervals until stream exhaustion or errors.
loop {
let mut right_chunks = vec![];
// Produce an aligned interval.
'inner: loop {
let mut combined = stream::select_with_strategy(
left.by_ref().map(Either::Left),
right.by_ref().map(Either::Right),
|_: &mut ()| PollNext::Left,
);
match combined.next().await {
Some(Either::Left(Ok(Message::Chunk(c)))) => yield InternalMessage::Chunk(c),
Some(Either::Right(Ok(Message::Chunk(c)))) => right_chunks.push(c),
Some(Either::Left(Ok(Message::Barrier(b)))) => {
let mut remain = chunks_until_barrier(right.by_ref(), b.clone())
.try_collect()
.await?;
right_chunks.append(&mut remain);
yield InternalMessage::Barrier(right_chunks, b);
break 'inner;
}
Some(Either::Right(Ok(Message::Barrier(b)))) => {
#[for_await]
for chunk in chunks_until_barrier(left.by_ref(), b.clone()) {
yield InternalMessage::Chunk(chunk?);
}
yield InternalMessage::Barrier(right_chunks, b);
break 'inner;
}
Some(Either::Left(Err(e)) | Either::Right(Err(e))) => return Err(e),
Some(
Either::Left(Ok(Message::Watermark(_)))
| Either::Right(Ok(Message::Watermark(_))),
) => todo!("https://github.com/risingwavelabs/risingwave/issues/6042"),
None => return Ok(()),
}
}
}
}

impl<S: StateStore, const T: JoinTypePrimitive> TemporalJoinExecutor<S, T> {
#[allow(dead_code)]
#[allow(clippy::too_many_arguments)]
pub fn new(
ctx: ActorContextRef,
left: BoxedExecutor,
right: BoxedExecutor,
table: StorageTable<S>,
left_join_keys: Vec<usize>,
right_join_keys: Vec<usize>,
null_safe: Vec<bool>,
pk_indices: PkIndices,
output_indices: Vec<usize>,
executor_id: u64,
watermark_epoch: AtomicU64Ref,
metrics: Arc<StreamingMetrics>,
chunk_size: usize,
) -> Self {
let schema_fields = [left.schema().fields.clone(), right.schema().fields.clone()].concat();

let schema: Schema = output_indices
.iter()
.map(|&idx| schema_fields[idx].clone())
.collect();

let alloc = StatsAlloc::new(Global).shared();

let cache = new_with_hasher_in(watermark_epoch, DefaultHasher::default(), alloc);

Self {
ctx,
left,
right,
right_table: TemporalSide {
source: table,
cache,
},
left_join_keys,
right_join_keys,
null_safe,
output_indices,
schema,
chunk_size,
pk_indices,
identity: format!("TemporalJoinExecutor {:X}", executor_id),
metrics,
}
}

#[try_stream(ok = Message, error = StreamExecutorError)]
async fn into_stream(mut self) {
let (left_map, right_map) = StreamChunkBuilder::get_i2o_mapping(
self.output_indices.iter().cloned(),
self.left.schema().len(),
self.right.schema().len(),
);

let mut prev_epoch = None;
#[for_await]
for msg in align_input(self.left, self.right) {
match msg? {
InternalMessage::Chunk(chunk) => {
let mut builder = StreamChunkBuilder::new(
self.chunk_size,
&self.schema.data_types(),
left_map.clone(),
right_map.clone(),
);
let epoch = prev_epoch.expect("Chunk data should come after some barrier.");
for (op, row) in chunk.rows() {
let key = row.project(&self.left_join_keys);
if key
.iter()
.zip_eq_fast(self.null_safe.iter())
.any(|(datum, can_null)| datum.is_none() && !*can_null)
{
continue;
}
if let Some(right_row) = self.right_table.lookup(key, epoch).await? {
if let Some(chunk) = builder.append_row(op, row, &right_row) {
yield Message::Chunk(chunk);
}
} else if T == JoinType::LeftOuter {
if let Some(chunk) = builder.append_row_update(op, row) {
yield Message::Chunk(chunk);
}
}
}
if let Some(chunk) = builder.take() {
yield Message::Chunk(chunk);
}
}
InternalMessage::Barrier(updates, barrier) => {
prev_epoch = Some(barrier.epoch.curr);
self.right_table
.update(updates, &self.right_join_keys, barrier.epoch.curr);
yield Message::Barrier(barrier)
}
}
}
}
}

impl<S: StateStore, const T: JoinTypePrimitive> Executor for TemporalJoinExecutor<S, T> {
fn execute(self: Box<Self>) -> super::BoxedMessageStream {
self.into_stream().boxed()
}

fn schema(&self) -> &Schema {
&self.schema
}

fn pk_indices(&self) -> super::PkIndicesRef<'_> {
&self.pk_indices
}

fn identity(&self) -> &str {
self.identity.as_str()
}
}