Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watermark): fix merge watermark on scale #8223

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Feb 28, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix unwrap panic when scaling the BufferedWatermark and add a simple test for that.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing part LGTM.

@yuhao-su
Copy link
Contributor

The watermark part LGTM

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #8223 (e2f448b) into main (a28f711) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main    #8223   +/-   ##
=======================================
  Coverage   71.57%   71.58%           
=======================================
  Files        1131     1131           
  Lines      182817   182822    +5     
=======================================
+ Hits       130859   130876   +17     
+ Misses      51958    51946   -12     
Flag Coverage Δ
rust 71.58% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/watermark/mod.rs 64.17% <78.57%> (+2.27%) ⬆️
src/stream/src/executor/hash_join.rs 97.31% <100.00%> (+<0.01%) ⬆️
src/storage/src/hummock/compactor/mod.rs 80.38% <0.00%> (-0.20%) ⬇️
src/common/src/cache.rs 97.26% <0.00%> (+0.10%) ⬆️
...rc/storage/hummock_sdk/src/filter_key_extractor.rs 93.89% <0.00%> (+0.25%) ⬆️
src/batch/src/executor/group_top_n.rs 74.70% <0.00%> (+6.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BugenZhao BugenZhao added this pull request to the merge queue Feb 28, 2023
Merged via the queue into main with commit 63890f6 Feb 28, 2023
@BugenZhao BugenZhao deleted the bz/scale-watermark branch February 28, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: watermark buffer panics when scaling
3 participants