Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix start table key panic when there are only range-tombstones #8189

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

Little-Wallace
Copy link
Contributor

@Little-Wallace Little-Wallace commented Feb 27, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #8186

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@Little-Wallace Little-Wallace marked this pull request as ready for review February 27, 2023 03:20
@Little-Wallace Little-Wallace changed the title fix panic start table key fix(storage): fix start table key panic when there are only range-tombstones Feb 27, 2023
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@hzxa21
Copy link
Collaborator

hzxa21 commented Feb 27, 2023

Why is this not captured by the daily delete range integration test?

@Little-Wallace
Copy link
Contributor Author

Why is this not captured by the daily delete range integration test?

It cause that the probability of generate a empty batch with only range-tombstone is too small..

@mergify
Copy link
Contributor

mergify bot commented Feb 27, 2023

Hey @Little-Wallace, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with git commit --allow-empty -m "rerun" && git push.

Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TennyZhuang TennyZhuang added this pull request to the merge queue Feb 27, 2023
@Little-Wallace Little-Wallace removed this pull request from the merge queue due to a manual request Feb 27, 2023
@Little-Wallace Little-Wallace added this pull request to the merge queue Feb 27, 2023
Merged via the queue into risingwavelabs:main with commit 8e9f344 Feb 27, 2023
@Little-Wallace Little-Wallace deleted the fix-table-key branch February 27, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hummock prune_overlap panicked
4 participants