-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): workaround for toolchain upgrade #5980
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5980 +/- ##
==========================================
- Coverage 74.67% 74.62% -0.06%
==========================================
Files 928 930 +2
Lines 147900 148422 +522
==========================================
+ Hits 110450 110759 +309
- Misses 37450 37663 +213
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/hold, let's remove performance-related workarounds before starting review. |
specifically |
Signed-off-by: Bugen Zhao <i@bugenzhao.com> remove redundant code Signed-off-by: Bugen Zhao <i@bugenzhao.com> cleanup Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
d62294c
to
702edef
Compare
write anytime broken by a wrong refactor in merge iterator. will fix tomorrow 🥵 |
Really ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Bugen Zhao 2 i@bugenzhao.com
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR mainly removes some unnecessary generics in the storage code.
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)