Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SqlSmith): gen Table Subquery EXISTS #4431

Merged
merged 14 commits into from
Nov 26, 2022
Merged

feat(SqlSmith): gen Table Subquery EXISTS #4431

Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
97b243f
Implement exists
marvenlee2486 Aug 3, 2022
99a36bc
Merge Conflict
marvenlee2486 Aug 4, 2022
47d788c
Fix formatting
marvenlee2486 Aug 4, 2022
ec54924
Add correlated query
marvenlee2486 Aug 9, 2022
282ecdd
Restore unwanted changes
marvenlee2486 Aug 9, 2022
dd2b37e
Merge branch 'main' into zongyu/sqlsmith_table_sub
marvenlee2486 Nov 14, 2022
07b3d82
Edit Syntax error
marvenlee2486 Nov 14, 2022
1a72911
Allow subquery without agg
marvenlee2486 Nov 14, 2022
c263705
Workaround subquery and inside_agg but there is a few problem yet
marvenlee2486 Nov 14, 2022
99ad100
Merge branch 'main' into zongyu/sqlsmith_table_sub
marvenlee2486 Nov 24, 2022
fd45ada
Test changed to no subquery first
marvenlee2486 Nov 25, 2022
fa10416
Done implementation
marvenlee2486 Nov 25, 2022
b88da6a
Merge branch 'main' into zongyu/sqlsmith_table_sub
mergify[bot] Nov 25, 2022
1845a80
Merge branch 'main' into zongyu/sqlsmith_table_sub
marvenlee2486 Nov 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/tests/sqlsmith/src/expr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ impl<'a, R: Rng> SqlGenerator<'a, R> {
let range = if can_agg & !inside_agg { 99 } else { 90 };

match self.rng.gen_range(0..=range) {
0..=80 => self.gen_func(typ, can_agg, inside_agg),
0..=70 => self.gen_func(typ, can_agg, inside_agg),
71..=80 => self.gen_exists(typ),
81..=90 => self.gen_cast(typ, can_agg, inside_agg),
91..=99 => self.gen_agg(typ),
// TODO: There are more that are not in the functions table, e.g. CAST.
Expand Down Expand Up @@ -181,6 +182,16 @@ impl<'a, R: Rng> SqlGenerator<'a, R> {
.unwrap_or_else(|| self.gen_simple_scalar(ret))
}

fn gen_exists(&mut self, ret: DataTypeName) -> Expr {
// TODO: Streaming nested loop join is not implemented yet.
// Tracked by: <https://github.com/singularity-data/risingwave/issues/2655>.
if self.is_mview || ret != DataTypeName::Boolean {
return self.gen_simple_scalar(ret);
};
let (subquery, _) = self.gen_local_query();
Expr::Exists(Box::new(subquery))
}

fn gen_agg(&mut self, ret: DataTypeName) -> Expr {
let funcs = match AGG_FUNC_TABLE.get(&ret) {
None => return self.gen_simple_scalar(ret),
Expand Down