Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqlsmith): enable sub-query generation #4216

Merged
merged 8 commits into from
Aug 1, 2022
Merged

Conversation

marvenlee2486
Copy link
Contributor

@marvenlee2486 marvenlee2486 commented Jul 27, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Refer to a related PR or issue link (optional)

related to #3935
close #4215

@marvenlee2486
Copy link
Contributor Author

marvenlee2486 commented Jul 27, 2022

Need to solve this first #4215,
Solved in this PR dy

@marvenlee2486 marvenlee2486 marked this pull request as ready for review July 27, 2022 08:55
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #4216 (04f4b12) into main (161cb22) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4216      +/-   ##
==========================================
- Coverage   74.32%   74.32%   -0.01%     
==========================================
  Files         844      844              
  Lines      122407   122407              
==========================================
- Hits        90985    90983       -2     
- Misses      31422    31424       +2     
Flag Coverage Δ
rust 74.32% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/manager/id.rs 94.02% <0.00%> (-0.55%) ⬇️
src/common/src/types/ordered_float.rs 28.91% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

@kwannoel kwannoel changed the title feat(Enable Gen_query): Part 1 feat(sqlsmith): enable sub-query generation Jul 28, 2022
src/tests/sqlsmith/src/relation.rs Outdated Show resolved Hide resolved
src/tests/sqlsmith/src/lib.rs Outdated Show resolved Hide resolved
@marvenlee2486
Copy link
Contributor Author

@kwannoel @neverchanje , I have made the changes to the lateral_contexts already. It is ready for approval.

@mergify mergify bot merged commit 293b177 into main Aug 1, 2022
@mergify mergify bot deleted the zongyu/sqlsmith_subquery branch August 1, 2022 06:33
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
* Solve bug 1

* Resolve error

* Resolved Comments

* Undo enable agg

* remove lateralcontexts

* Fix formatting

* Control recursion

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@kwannoel kwannoel mentioned this pull request Jan 11, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants