Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(agg): separate semantics of AggKind and AggType #18640

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Conversation

stdrc
Copy link
Contributor

@stdrc stdrc commented Sep 23, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Just a preparation for fixing UDAF as window function. #18436

The rationale is that I'll introduce a new proto message called AggType which contains agg_kind and other metadata like UDF meta or wrapped scalar expression node.

So after this, the word kind will be used for detailed, simple enum types, type will be used for high-level classes that can be either simple or compound.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Copy link
Contributor Author

stdrc commented Sep 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on Graphite Graphite

@stdrc stdrc changed the title rename AggCall.Type to AggCall.Kind refactor(agg): Sep 23, 2024
@stdrc stdrc changed the title refactor(agg): refactor(agg): separate semantics of AggKind and AggType Sep 23, 2024
@stdrc stdrc marked this pull request as ready for review September 23, 2024 09:14
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

エレガント!

@stdrc stdrc added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit f3bd456 Sep 23, 2024
38 of 41 checks passed
@stdrc stdrc deleted the rc/rename-agg-kind branch September 23, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants