Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agg): fix embedded UDAF as window function #18632

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stdrc
Copy link
Contributor

@stdrc stdrc commented Sep 23, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fixes #18436.

As a quick fix, currently the retract method of embedded UDAF, if defined, is not utilized. Let's fix the functionality first, and optimize the performance in later PR, which requires some more work to do.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor Author

stdrc commented Sep 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on Graphite Graphite

@stdrc stdrc changed the title store udf meta in protobuf fix(agg): fix UDAF as window function Sep 23, 2024
@github-actions github-actions bot added type/fix Bug fix and removed Invalid PR Title labels Sep 23, 2024
@stdrc stdrc force-pushed the rc/fix-agg-as-window-func branch 2 times, most recently from ce07651 to 65550e6 Compare September 23, 2024 09:50
@stdrc stdrc changed the base branch from rc/rename-pb-agg-kind to rc/rename-agg-kind September 23, 2024 09:51
Base automatically changed from rc/rename-agg-kind to main September 23, 2024 10:06
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
…pScalar`

Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
@stdrc stdrc marked this pull request as ready for review September 23, 2024 12:18
@stdrc stdrc changed the title fix(agg): fix UDAF as window function fix(agg): fix embedded UDAF as window function Sep 23, 2024
@graphite-app graphite-app bot requested a review from a team September 23, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: UDAF can not be used as window function
1 participant