refactor(source): move protobuf to codec crate, and refactor tests #18507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
xxchan
force-pushed
the
xxchan/constitutional-gerbil
branch
from
7a814bf
to
3f75b9a
Compare
xxchan
force-pushed
the
xxchan/constitutional-gerbil
branch
2 times, most recently
from
8dfd00a
to
cb1d07c
Compare
9 tasks
xiangjinwu
approved these changes
Sep 13, 2024
| Serialize, | ||
| } | ||
|
|
||
| pub fn compile_pb( |
There was a problem hiding this comment.
This is shared between source/parser/decoder and sink/encoder, so it was in schema at the same level as source or sink. After moving to codec it shall not be part of decoder.
| //! ## Why not directly test the uppermost layer `AvroParserConfig` and `AvroAccessBuilder`? | ||
| //! | ||
| //! Because their interface are not clean enough, and have complex logic like schema registry. | ||
| //! We might need to separate logic to make them clenaer and then we can use it directly for testing. |
There was a problem hiding this comment.
Suggested change
| //! We might need to separate logic to make them clenaer and then we can use it directly for testing. | |
| //! We might need to separate logic to make them cleaner and then we can use it directly for testing. |
- Previously each test case have a slightly different test style. Now they are unified into one simple and powerful one. - Previously we rely on manually compile the test .proto files. But we can compile it ourself in code. - Delete some e2e tests, which is not very helpful, but added complexity of test script. - Split `all-types` from `recursive` to reduce confusion. Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
force-pushed
the
xxchan/constitutional-gerbil
branch
from
cb1d07c
to
9f2cfd1
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
xxchan
added a commit
that referenced
this pull request
Sep 17, 2024
…18507) Signed-off-by: xxchan <xxchan22f@gmail.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
#17002 Similar to the refactors on Avro. Make it more understandable and easier to change/add tests
all-typesfromrecursiveto reduce confusion.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.