Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): deprecate pin/unpin snapshot #18493

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Sep 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR removes RPC/methods relevant to pin/unpin snapshot completely.

#18214

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@zwang28 zwang28 changed the title refactor(meta): completely remove pin/unpin snapshot refactor(meta): deprecate pin/unpin snapshot Sep 11, 2024
@zwang28 zwang28 force-pushed the wangzheng/deprecate_safe_epoch branch from 254a3e2 to 5e17dff Compare September 20, 2024 07:42
@zwang28 zwang28 marked this pull request as ready for review September 20, 2024 07:44
@zwang28 zwang28 requested a review from wenym1 September 20, 2024 07:44
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zwang28 zwang28 added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 409bc8d Sep 20, 2024
32 of 33 checks passed
@zwang28 zwang28 deleted the wangzheng/deprecate_safe_epoch branch September 20, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants