-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support per-fragment vnode count #18444
Open
BugenZhao
wants to merge
22
commits into
main
Choose a base branch
from
bz/var-vnode-user-facing-local
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+424
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on Graphite |
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
September 9, 2024 06:02
32d0692
to
afe9e79
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
from
September 9, 2024 06:02
3292eed
to
c4772c9
Compare
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
September 9, 2024 09:03
afe9e79
to
f168f35
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
from
September 9, 2024 09:03
c4772c9
to
166d631
Compare
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
September 9, 2024 09:10
f168f35
to
be13c79
Compare
4 tasks
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
from
September 9, 2024 09:10
166d631
to
31e2d77
Compare
4 tasks
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
September 10, 2024 07:30
be13c79
to
18e0165
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
3 times, most recently
from
September 11, 2024 06:17
a5afcdf
to
fce41b8
Compare
BugenZhao
changed the title
feat: specify vnode count for jobs via session config
feat: support per-fragment vnode count
Sep 11, 2024
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
September 12, 2024 08:06
23435d7
to
01ee86d
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
2 times, most recently
from
September 12, 2024 08:51
fa288c5
to
e4ef75f
Compare
4 tasks
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
2 times, most recently
from
September 13, 2024 06:13
640e7d8
to
fe25c89
Compare
4 tasks
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
September 13, 2024 10:13
34bdd9b
to
8b31007
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
from
September 13, 2024 10:13
fe25c89
to
4ae30fd
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
from
September 16, 2024 05:31
4ae30fd
to
9cdeee0
Compare
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
September 17, 2024 07:32
5d81f7e
to
edc11d9
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
from
September 17, 2024 07:32
9cdeee0
to
16b19b0
Compare
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
September 19, 2024 06:21
edc11d9
to
a516e1b
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
from
September 19, 2024 06:21
16b19b0
to
e5b0095
Compare
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
from
September 20, 2024 15:51
e5b0095
to
0d6830b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This is a progress towards #15900.
In previous PRs, we mainly focused on refactoring codes from different modules to avoid directly referencing the global constant of
VirtualNode::COUNT
, but infer it from the context or directly accept it as a parameter.In this PR, we introduce the
vnode_count
field forTable
andStreamFragmentGraph
, update the logic for its maintenance. Many TODOs of directly usingVirtualNode::COUNT
are fixed by reading the values fromFragment
orTableDesc
.Note that there's still no user-facing changes in this PR, but we are now quite close to that. However, there are still some unaddressed TODOs that may require changes in behavior. We leave this in future PRs.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.