refactor(test): kafka sink with protobuf/avro as inline style #18193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangjinwu
force-pushed
the
test-sink-inline-protobuf
branch
from
42cefb6
to
b97bfd5
Compare
xiangjinwu
commented
Aug 22, 2024
| @@ -150,20 +150,7 @@ echo "preparing confluent schema registry" | |||
| python3 -m pip install --break-system-packages requests confluent-kafka | |||
There was a problem hiding this comment.
But this still needs to be executed before running python3 e2e_test/sink/kafka/register_schema.py
There was a problem hiding this comment.
We can add a README in e2e test dir to note the required dependency
xxchan
pushed a commit
that referenced
this pull request
Sep 17, 2024
Signed-off-by: xxchan <xxchan22f@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.