Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): use iceberg-rust instead of icelake to enumerate iceberg files and snapshots. #17558

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Jul 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/connector/src/source/iceberg/mod.rs Outdated Show resolved Hide resolved
chenzl25 and others added 2 commits July 4, 2024 13:12
Co-authored-by: Eric Fu <eric@singularity-data.com>
@chenzl25
Copy link
Contributor Author

chenzl25 commented Jul 4, 2024

It seems iceberg-rust introduces some breaking changes on s3a:// and s3:// protocols

DataInvalid => Invalid s3 url: s3a://iceberg/demo_db/e2e_demo_table/metadata/snap-1-1-7b361ebc-1b38-4dee-aa15-eeb7f9416b63.avro, should start with s3://iceberg/

@chenzl25
Copy link
Contributor Author

chenzl25 commented Jul 4, 2024

It seems iceberg-rust introduces some breaking changes on s3a:// and s3:// protocols

DataInvalid => Invalid s3 url: s3a://iceberg/demo_db/e2e_demo_table/metadata/snap-1-1-7b361ebc-1b38-4dee-aa15-eeb7f9416b63.avro, should start with s3://iceberg/

apache/iceberg-rust#434

@chenzl25
Copy link
Contributor Author

chenzl25 commented Jul 5, 2024

It seems iceberg-rust introduces some breaking changes on s3a:// and s3:// protocols

DataInvalid => Invalid s3 url: s3a://iceberg/demo_db/e2e_demo_table/metadata/snap-1-1-7b361ebc-1b38-4dee-aa15-eeb7f9416b63.avro, should start with s3://iceberg/

apache/iceberg-rust#434

This is an expected behavior. Let's move on.

@chenzl25 chenzl25 added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit 0e64bc0 Jul 5, 2024
32 of 33 checks passed
@chenzl25 chenzl25 deleted the dylan/use_iceberg_rust_instead_of_icelake_in_fe branch July 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants