Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sink): DRY SinkFormatterImpl::new #16575

Merged
merged 7 commits into from
May 6, 2024

minor refactors

da8df3d
Select commit
Loading
Failed to load commit list.
Merged

refactor(sink): DRY SinkFormatterImpl::new #16575

minor refactors
da8df3d
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-05-06 08:20:23 ago

2 / 8 tasks completed

6 tasks still to be completed

Details

Required Tasks

Task Status
supported schemas.enable option for format plain encode json, which was only available for format upsert encode json #12113. Incomplete
fixed partition skew problem when encode template is used with format plain without key. The encode json case was fixed in #12810. Incomplete
I have written necessary rustdoc comments Completed
I have added necessary unit tests and integration tests Incomplete
I have added test labels as necessary. See details. Incomplete
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934). Incomplete
My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future). Incomplete
All checks passed in ./risedev check (or alias, ./risedev c) Completed
My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details) Incomplete
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) Incomplete