Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): eliminate all the warnings of cargo doc --document-private-items #1519

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Apr 1, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!
As the title.

Shall we now make cargo doc a part of CI and let it fail on warnings?

Refer to a related PR or issue link (optional)

#1437

@github-actions github-actions bot added the type/fix Bug fix label Apr 1, 2022
@lmatz lmatz requested a review from TennyZhuang April 1, 2022 06:17
@skyzh
Copy link
Contributor

skyzh commented Apr 1, 2022

Shall we now make cargo doc a part of CI and let it fail on warnings?

cargo doc doesn't support fail on warning IIRC 🤣

@lmatz
Copy link
Contributor Author

lmatz commented Apr 1, 2022

Let me investigate this a bit rust-lang/rust#79792

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #1519 (0f40c85) into main (7d7a4b3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1519   +/-   ##
=========================================
  Coverage     70.45%   70.46%           
  Complexity     2766     2766           
=========================================
  Files          1031     1031           
  Lines         90539    90539           
  Branches       1790     1790           
=========================================
+ Hits          63793    63795    +2     
+ Misses        25855    25853    -2     
  Partials        891      891           
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 72.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/barrier/command.rs 53.44% <ø> (ø)
rust/meta/src/barrier/info.rs 100.00% <ø> (ø)
rust/meta/src/barrier/mod.rs 79.67% <ø> (ø)
rust/meta/src/stream/graph/stream_graph.rs 58.26% <ø> (ø)
rust/meta/src/stream/scheduler.rs 97.17% <ø> (ø)
rust/meta/src/stream/stream_manager.rs 75.72% <ø> (ø)
rust/stream/src/executor/lookup/impl_.rs 98.02% <ø> (ø)
rust/stream/src/executor/lookup/sides.rs 11.11% <ø> (ø)
rust/stream/src/executor_v2/error.rs 0.00% <ø> (ø)
rust/stream/src/lib.rs 100.00% <ø> (ø)
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lmatz lmatz enabled auto-merge (squash) April 1, 2022 06:39
@lmatz lmatz merged commit 809f06a into main Apr 1, 2022
@lmatz lmatz deleted the lz/doc branch April 1, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants