Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error message for function argument mismatch #14435

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

wangrunji0408
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

resolve #9273

This PR replaces unsupported function error by function does not exist:

 dev=> select foo();
 ERROR:  Failed to run the query

 Caused by these errors (recent errors listed first):
   1: Failed to bind expression: foo()
+  2: function foo() does not exist
-  2: Feature is not yet implemented: unsupported function: "foo"
-Tracking issue: https://github.com/risingwavelabs/risingwave/issues/112

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Signed-off-by: Runji Wang <wangrunji0408@163.com>
src/common/src/error.rs Show resolved Hide resolved
src/frontend/src/binder/expr/function.rs Outdated Show resolved Hide resolved
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
@wangrunji0408 wangrunji0408 added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit a30583f Jan 9, 2024
26 of 27 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/no-function-err-msg branch January 9, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

udf: improve error message for function argument mismatch
2 participants