Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: poll barrier complete rpc in barrier manager worker loop #14419

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Jan 8, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously in global barrier manager, the finish of barrier_complete rpc is notified by a mpsc channel, which may receive stale rpc result after recovery.

In this PR, we change to use a oneshot channel to notify the barrier completion of each epoch. The oneshot receiver will be pushed to a FuturesUnordered and gets polled in the global barrier manager worker loop. In this way, during failure recovery, we can avoid receiving stale completion result.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

src/meta/src/barrier/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wenym1 wenym1 enabled auto-merge January 9, 2024 08:05
@wenym1
Copy link
Contributor Author

wenym1 commented Jan 9, 2024

Some methods related to barrier rpc is moved to rpc.rs without a line of change to make the code more organized.

@wenym1 wenym1 added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit d20632d Jan 9, 2024
26 of 27 checks passed
@wenym1 wenym1 deleted the yiming/poll-barrier-rpc-complete branch January 9, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants