fix(compactor): fix put key miss tombstone #14233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
|
Shall we cherry-pick it to v1.5? |
Li0k
approved these changes
Dec 27, 2023
MrCroxx
reviewed
Dec 27, 2023
| self.executor.run(&mut iter, target_key).await?; | ||
| } else { | ||
| let is_new_user_key = !self.executor.last_key.user_key.eq(&smallest_key.user_key); | ||
| if !self.executor.builder.need_flush() && is_new_user_key { |
There was a problem hiding this comment.
Could you please add some comments here? It's kind of confusing.
There was a problem hiding this comment.
Done. I have add comment for it.
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In fast compact, if the last key is added to sstable one by one, we must check the start key of next block before we copy it into new sstable. Because if the last key is a tombstone and we have removed it, all keys of next block must check whether they share the same user key with the last key.
This bug may be one of the reasons which cause stream inconsistant: #14031
Because if one tombstone is deleted but we keep the put key following it, streaming state may find a deleted key in query result.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.