Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(streaming): add fuzz test for materialize handle conflict #14166

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Dec 23, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Have checked the memtable's consistent check taking effect by deliberately introducing some bugs in the materialize executor.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the component/test Test related issue. label Dec 23, 2023
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (4bab13a) 67.86% compared to head (5f7e7a6) 67.86%.
Report is 4 commits behind head on main.

Files Patch % Lines
...frontend/src/expr/function_impl/pg_get_indexdef.rs 0.00% 42 Missing ⚠️
src/frontend/src/catalog/index_catalog.rs 0.00% 20 Missing ⚠️
src/frontend/src/catalog/root_catalog.rs 0.00% 12 Missing ⚠️
src/stream/src/executor/mview/materialize.rs 97.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14166      +/-   ##
==========================================
- Coverage   67.86%   67.86%   -0.01%     
==========================================
  Files        1558     1559       +1     
  Lines      269686   269844     +158     
==========================================
+ Hits       183033   183122      +89     
- Misses      86653    86722      +69     
Flag Coverage Δ
rust 67.86% <51.89%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fuyufjh
Copy link
Member

fuyufjh commented Dec 26, 2023

It seems duplicated with #11712? Except the ConflictBehavior is introduced.

@BugenZhao
Copy link
Member

Except the ConflictBehavior is introduced.

There was a critical bug: #13346

@st1page
Copy link
Contributor Author

st1page commented Dec 27, 2023

It seems duplicated with #11712? Except the ConflictBehavior is introduced.

This PR focuses on the implementation of MaterializeExecutor's conflict-handling

@st1page st1page changed the title test: add fuzz test for materialize handle conflict test(streaming): add fuzz test for materialize handle conflict Dec 28, 2023
@st1page st1page enabled auto-merge January 2, 2024 08:32
@st1page st1page added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit 58e1326 Jan 3, 2024
29 of 30 checks passed
@st1page st1page deleted the sts/fuzz_test_for_materialize_handle_conflict branch January 3, 2024 11:55
xxhZs added a commit that referenced this pull request Jan 4, 2024
fix

chore: fix typos linted by cSpell (#14306)

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix(over window): fix over window range cache shortcut return (#14311)

Signed-off-by: Richard Chien <stdrc@outlook.com>

fix(stream): rowIdGen executor handle invisible delete record (#14237)

feat(storage): Improve task measurement on the compactor side with parallelism (#13812)

feat: introduce rw_streaming_parallelism system view (#14261)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

chore: Add type check to alter parallelism statement. (#14323)

Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>

refactor(error): add more context for jvm error (#14302)

chore: update help message for scale command (#14332)

Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>

fix: fix panic in `ctl meta source-split-info` (#14334)

Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>

test(streaming): add fuzz test for materialize handle conflict (#14166)

add mock coordination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants