Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CI #3

Open
wants to merge 4 commits into
base: risczero
Choose a base branch
from
Open

Enable CI #3

wants to merge 4 commits into from

Conversation

jjtny1
Copy link

@jjtny1 jjtny1 commented Oct 2, 2023 •
edited
Loading

Enable CI tests and add cargo risczero test

nategraf and others added 4 commits June 13, 2023 10:39
@nategraf
Use RISC Zero BigInt multiplier to accelerate k256 within the zkVM gu…
44b1fc2 
…est (#1)

Building on risc0/risc0#466, this PR enables the use of the RISC Zero 256-bit modular multiplication accelerator within guest code for k256 arithmetic, including ECDSA.

A key application, ECDSA verification is accelerated significantly from a little over 5M cycles without acceleration support to about 890k cycles.

Based on k256@v0.13.1
@nategraf
fix potential overflow error in FieldElement8x32R0::add (#2)
5fea17d
@jjtny1
enable ci
57c047c
@jjtny1
add risczero test
382bf11
flaub
flaub requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@flaub flaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with other PRs, I think we should try to reduce the number of checks to something in the 2-5 range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaub flaub flaub requested changes

@nategraf nategraf Awaiting requested review from nategraf

@SchmErik SchmErik Awaiting requested review from SchmErik

@capossele capossele Awaiting requested review from capossele

@Cardosaum Cardosaum Awaiting requested review from Cardosaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjtny1 @flaub @nategraf