Skip to content

Commit

Permalink
Add TODO comment for bug shergin spotted
Browse files Browse the repository at this point in the history
  • Loading branch information
Adam Comella committed Feb 20, 2019
1 parent 20100d0 commit 34f9cb9
Showing 1 changed file with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,14 @@ public void dirty() {
} else if (getParent() != null) {
// Virtual nodes aren't involved in layout but they need to have the dirty signal
// propagated to their ancestors.
//
// TODO: There are some edge cases that currently aren't supported. For example, if the size
// of your inline image/view changes, its size on-screen is not be updated. Similarly,
// if the size of a view inside of an inline view changes, its size on-screen is not
// updated. The problem may be that dirty propagation stops at inline views because the
// parent of each inline view is null. A possible fix would be to implement an `onDirty`
// handler in Yoga that will propagate the dirty signal to the ancestors of the inline view.
//
getParent().dirty();
}
}
Expand Down

0 comments on commit 34f9cb9

Please sign in to comment.