Fix __VITE_PRELOAD__ regression in vite 5.3 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @richardtallent could you please help review and tag a release? Thank you! Feel free to make modifications, like just removing the quote, I am fine with that. |
richardtallent
approved these changes
Jun 20, 2024
|
Done |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
"__VITE_PRELOAD__"replacement no longer works in vite 5.3 because of this change: vitejs/vite#16562The reason is that the produced marker is just
__VITE_PRELOAD__, no quotes.I updated the regex to support both versions, by taking the quote as an optional pattern.
Tested both vite 5.3 and vite 5.2.12, working fine.