Added using of NetworkChange.NetworkAddressChanged instead of Timer #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed AnswersContainsAdditionalRecords functionality
|
It's failing on MAC OS X, see the CI build |
richardschneider
requested changes
Nov 8, 2018
| NetworkInterfaceDiscovered?.Invoke(this, new NetworkInterfaceEventArgs | ||
| { | ||
| NetworkInterfaces = newNics | ||
| }); | ||
| } | ||
|
|
||
| NetworkChange.NetworkAddressChanged -= OnNetworkAddressChanged; | ||
| NetworkChange.NetworkAddressChanged += OnNetworkAddressChanged; |
There was a problem hiding this comment.
Why removing then adding again?
| @@ -592,11 +567,10 @@ async void Listener() | |||
| // eat the exception | |||
| } | |||
|
|
|||
| receiver.Dispose(); | |||
There was a problem hiding this comment.
Shouldn't the receiver be disposed?
richardschneider
requested changes
Nov 8, 2018
| mdns.NetworkInterfaceDiscovered += (s, e) => | ||
| { | ||
| sd.QueryServiceInstances(service.ServiceName); | ||
| }; |
There was a problem hiding this comment.
You should not be changing the existing tests. This implies a breaking change.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed AnswersContainsAdditionalRecords functionality