Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handlers for parser errors #36

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

dries
Copy link

@dries dries commented Jun 28, 2017

Currently there is an unhandled error event when syntactically incorrect multipart data is sent by the client which causes node.js to crash. This PR adds basic handlers that allow the node server to live on.

events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Part terminated early due to unexpected end of multipart data
    at /var/www/web/server/node_modules/dicer/lib/Dicer.js:65:36
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

@coveralls
Copy link

coveralls commented Jun 28, 2017

Coverage Status

Coverage increased (+0.1%) to 95.349% when pulling 0713f6f on dries:master into b9ee66e on richardgirges:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 95.349% when pulling 0713f6f on dries:master into b9ee66e on richardgirges:master.

@richardgirges
Copy link
Owner

Solid 👍

@richardgirges richardgirges merged commit 27b6136 into richardgirges:master Jun 30, 2017
This was referenced Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants