support kube tty

rhelmot · Jul 15, 2024 · 3764262 · 3764262
1 parent e72b653
commit 3764262
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/pydatatask/executor/container_manager.py b/pydatatask/executor/container_manager.py
@@ -341,6 +341,7 @@ def build_pod_spec(
         quota: Quota,
         mounts: Dict[str, str],
         privileged: bool,
+        tty: bool,
     ):
         mount_info = {
             provided_name: (
@@ -378,6 +379,8 @@ def build_pod_spec(
                         for mountpoint, name in mounts.items()
                         if not mount_info[name][1].null
                     ],
+                    "tty": tty,
+                    "stdin": tty,
                 }
             ],
             "volumes": [info.to_kube(name) for (name, info) in mount_info.values() if not info.null],
@@ -397,9 +400,7 @@ async def launch(
         privileged: bool,
         tty: bool,
     ):
-        if tty:
-            raise ValueError("Cannot do tty from a container on a kube cluster")
-        podspec = self.build_pod_spec(image, entrypoint, cmd, environ, quota, mounts, privileged)
+        podspec = self.build_pod_spec(image, entrypoint, cmd, environ, quota, mounts, privileged, tty)
         await self.cluster.launch(
             task,
             job,

diff --git a/pydatatask/executor/container_set_manager.py b/pydatatask/executor/container_set_manager.py
@@ -247,9 +247,7 @@ async def launch(
         privileged: bool,
         tty: bool,
     ):
-        if tty:
-            raise ValueError("Cannot do tty from a container on a kube cluster")
-        pod_spec = self.inner.build_pod_spec(image, entrypoint, cmd, environ, quota, mounts, privileged)
+        pod_spec = self.inner.build_pod_spec(image, entrypoint, cmd, environ, quota, mounts, privileged, tty)
         pod_spec["restartPolicy"] = "Always"
         nonce = "".join(random.choice(string.ascii_lowercase) for _ in range(8))
         pod_template = {