Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create setup.py #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create setup.py #3

wants to merge 1 commit into from

Conversation

epurdy
Copy link

@epurdy epurdy commented Nov 16, 2022

No description provided.

rfeinman
rfeinman requested changes Nov 16, 2022
View reviewed changes
Copy link
Owner

@rfeinman rfeinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Can you please change the url to https://github.com/rfeinman/pytorch-lasso? And can you add python_requires=">=3.7"?

Also, let's use a less strict pytorch version requirement, e.g. torch>=1.12.0. I wrote this repo with 1.9.0, after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfeinman rfeinman rfeinman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epurdy @rfeinman