Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flushHeaders method #18

Closed
wants to merge 1 commit into from
Closed

Use flushHeaders method #18

wants to merge 1 commit into from

Conversation

fijimunkii
Copy link

wKovacs64
wKovacs64 reviewed May 11, 2017
View reviewed changes
Copy link
Contributor

@wKovacs64 wKovacs64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will skip the compression middleware's monkey-patched version of flush() if response.flushHeaders() is present, won't it? I tried similar in #7.

@fijimunkii
Copy link
Author

Thanks @wKovacs64 - I see now what was intended there

@fijimunkii fijimunkii closed this May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wKovacs64 wKovacs64 wKovacs64 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fijimunkii @wKovacs64