Make NodeID required where needed #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the spec validator option for requiring NodeID, as the current CSI spec makes it explicitly required for both the NodeGetInfoResponse and the ControllerPublishVolumeRequest, so there is no point in having a option to enable this -- we should always check for it. Furthermore, NodeID is actually optional for the ControllerUnpublishVolumeRequest, and when the NodeID is blank in that scenario the controller is supposed to unplish the volume from all nodes. So this patch updates the mock driver to have that behavior and adds tests to verify it.
codenrhoden
force-pushed
the
node_id_required
branch
from
1404ff5
to
521c060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the spec validator option for requiring NodeID, as
the current CSI spec makes it explicitly required for both the
NodeGetInfoResponse and the ControllerPublishVolumeRequest, so there is
no point in having a option to enable this -- we should always check for
it.
Furthermore, NodeID is actually optional for the
ControllerUnpublishVolumeRequest, and when the NodeID is blank in that
scenario the controller is supposed to unplish the volume from all
nodes. So this patch updates the mock driver to have that behavior and
adds tests to verify it.