Add option to disable field length checking #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a new option to explicitly disable the checking of CSI message field lenghts against the defined maximums found in the spec. This is in direct response to the observation of COs not adhering to this portion of the spec and commonly sending strings that are longer than the current default limit of 128 bytes. This leads consumers to use GoCSI with all spec validation disabled, which minimizes it's usefulness.
codenrhoden
force-pushed
the
disable-field-len
branch
from
9a82425
to
27bbd86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new option to explicitly disable the checking of CSI
message field lengths against the defined maximums found in the spec.
This is in direct response to the observation of COs not adhering to
this portion of the spec and commonly sending strings that are longer
than the current default limit of 128 bytes. This leads consumers to use
GoCSI with all spec validation disabled, which minimizes it's
usefulness.
Fixes #105