Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error with the latest dev build #916

Closed
Z3r0xh opened this issue Aug 9, 2024 · 5 comments
Closed

error with the latest dev build #916

Z3r0xh opened this issue Aug 9, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@Z3r0xh
Copy link

Z3r0xh commented Aug 9, 2024

Describe the bug
console spam

Software brand
NullcordX 3.8.8

Plugins
image

How To Reproduce
Steps to reproduce the behavior:
Just place the latest dev build and wait for the users to enter

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
Full server log (https://mclo.gs/e6bRQgD)

Additional context

NullcordX now accepts event packets, currently back to 2.4.1

@Z3r0xh Z3r0xh added the bug Something isn't working label Aug 9, 2024
@jonesdevelopment
Copy link

I'm currently using 2.4.1

Try the latest dev build from Jenkins:
https://ci.codemc.io/job/retrooper/job/packetevents/lastSuccessfulBuild/

@Z3r0xh
Copy link
Author

Z3r0xh commented Aug 9, 2024

I'm currently using 2.4.1

Try the latest dev build from Jenkins: https://ci.codemc.io/job/retrooper/job/packetevents/lastSuccessfulBuild/

The one I mean that failed was that one. 2.5.0. I mean I had to downgrade to 2.4.1 again

@jonesdevelopment
Copy link

The one I mean that failed was that one. 2.5.0. I mean I had to downgrade to 2.4.1 again

Oh, sorry, I misunderstood.

@Z3r0xh
Copy link
Author

Z3r0xh commented Aug 9, 2024

The one I mean that failed was that one. 2.5.0. I mean I had to downgrade to 2.4.1 again

Oh, sorry, I misunderstood.

Don't worry :D

@libraryaddict
Copy link
Contributor

So the problem with IJukeboxSong is that a Component can actually be a raw string.
Except I'm not familiar enough with packetevents and the utilities to know how that implementation would look.

A brief look into nms internals seems like a component is written as a raw string if it's simple enough, otherwise it's written as json.
So packetevents could just handle this all as a string but then I don't know how to handle https://github.com/retrooper/packetevents/blob/2.0/api/src/main/java/com/github/retrooper/packetevents/protocol/item/jukebox/JukeboxSongs.java#L47

The actual implemention of jukebox was wrong, because I had naively believed that the vanilla jukebox songs were being sent as I had experienced with the other registries. Turns out you need a datapack installed or the code never fires

retrooper added a commit that referenced this issue Aug 10, 2024
Fix #916 via removing explicit type call of nbt get
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants