bstats metrics do not collect snapshot & commit, solely version is ca…

…ptured.

api/src/main/java/com/github/retrooper/packetevents/util/PEVersion.java

@@ -271,14 +271,26 @@ public PEVersion clone() {
 
     /**
      * Converts the {@link PEVersion} to a string representation.
+     * If this is a stable release, the snapshot and the commit will not be included in the representation.
      *
-     * @return a string representation of the version.
+     * @return string representation of the version.
      */
     @Override
     public String toString() {
         return major + "." + minor + "." + patch + (snapshot && snapshotCommit != null ? ("+" + snapshotCommit + "-SNAPSHOT") : "");
     }
 
+    /**
+     * Converts the {@link PEVersion} to a string representation with guarantee that it
+     * will not have the commit attached to it.
+     * Useful for accessing the string representation for metrics
+     * as detailed information, such as the commit, is not required.
+     * @return guaranteed string representation without commit.
+     */
+    public String toStringWithoutSnapshot() {
+        return major + "." + minor + "." + patch;
+    }
+
     /**
      * Converts the {@link PEVersion} to an array of version numbers.
      * @deprecated since {@link PEVersion} instances now always use Semantic Versioning, and thus, returning an "amorphous" array,

bungeecord/src/main/java/io/github/retrooper/packetevents/bungee/factory/BungeePacketEventsBuilder.java

@@ -226,7 +226,7 @@ public void init() {
                     Metrics metrics = new Metrics(plugin, 11327);
                     //Just to have an idea of which versions of packetevents people use
                     metrics.addCustomChart(new Metrics.SimplePie("packetevents_version", () -> {
-                        return getVersion().toString();
+                        return getVersion().toStringWithoutSnapshot();
                     }));
 
                     PacketType.Play.Client.load();

spigot/src/main/java/io/github/retrooper/packetevents/factory/spigot/SpigotPacketEventsBuilder.java

@@ -143,8 +143,7 @@ public void init() {
 
                     Metrics metrics = new Metrics((JavaPlugin) plugin, 11327);
                     //Just to have an idea of which versions of packetevents people use
-                    metrics.addCustomChart(new Metrics.SimplePie("packetevents_version", () -> getVersion().toString()));
-
+                    metrics.addCustomChart(new Metrics.SimplePie("packetevents_version", () -> getVersion().toStringWithoutSnapshot()));
                     Bukkit.getPluginManager().registerEvents(new InternalBukkitListener(plugin), plugin);
 
                     if (lateBind) {

velocity/src/main/java/io/github/retrooper/packetevents/velocity/factory/VelocityPacketEventsBuilder.java

@@ -220,9 +220,10 @@ public void init() {
                     Object instance = plugin.getInstance().orElse(null);
                     if (instance != null) {
                         Metrics metrics = Metrics.createInstance(plugin, server, logger, dataDirectory, 11327);
+
                         //Just to have an idea of which versions of packetevents people use
                         metrics.addCustomChart(new Metrics.SimplePie("packetevents_version", () -> {
-                            return getVersion().toString();
+                            return getVersion().toStringWithoutSnapshot();
                         }));
                     }