Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternatives for 'hang', 'hanged' #83

Merged
merged 1 commit into from
Aug 10, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions data/en/suicide.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,12 @@
- a note from the deceased
inconsiderate:
- suicide note
- type: simple
note: When describing the behavior of computer software, using the word “hanged” needlessly invokes the topic of death by self-harm or lynching. Consider using the phrase “stopped responding to events” or “became unresponsive” instead.
considerate:
- the app stopped responding
- the app stopped responding to events
- the app became unresponsive
inconsiderate:
- hang
- hanged
1 change: 1 addition & 0 deletions rules.md
Original file line number Diff line number Diff line change
Expand Up @@ -423,3 +423,4 @@ This is used for one case: `master` and `slave`.
| `suicide-pact` | [simple](#simple) | `suicide epidemic`, `epidemic of suicides`, `suicide pact` | `rise in suicides` |
| `failed-suicide` | [simple](#simple) | `failed suicide`, `failed attempt`, `suicide failure` | `suicide attempt`, `attempted suicide` |
| `suicide-note` | [simple](#simple) | `suicide note` | `a note from the deceased` |
| `hang` | [simple](#simple) | `hang`, `hanged` | `the app stopped responding`, `the app stopped responding to events`, `the app became unresponsive` |
9 changes: 9 additions & 0 deletions test.js
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,15 @@ test('Phrasing', function(t) {
],
'a.d.h.d'
)
t.same(
process(
'The app hanged when dragging a window between a non-Retina and a Retina display'
),
[
'1:9-1:15: `hanged` may be insensitive, use `the app stopped responding`, `the app stopped responding to events`, `the app became unresponsive` instead'
],
'hang'
)

t.end()
})
Expand Down