Skip to content

Commit

Permalink
Add bitching, moaning, manned, unmanned
Browse files Browse the repository at this point in the history
Closes wooorm/alex#17.
  • Loading branch information
wooorm committed Sep 4, 2015
1 parent 6abb92c commit ee7c95e
Show file tree
Hide file tree
Showing 5 changed files with 192 additions and 27 deletions.
87 changes: 74 additions & 13 deletions lib/patterns.json
Original file line number Diff line number Diff line change
Expand Up @@ -3262,6 +3262,67 @@
],
"id": 203
},
{
"type": "simple",
"considerate": {
"staffed": "a",
"crewed": "a",
"pilotted": "a"
},
"inconsiderate": {
"manned": "a"
},
"categories": [
"a"
],
"id": 204
},
{
"type": "simple",
"considerate": {
"robotic": "a",
"automated": "a"
},
"inconsiderate": {
"unmanned": "a"
},
"categories": [
"a"
],
"id": 205
},
{
"type": "simple",
"considerate": {
"whining": "a",
"complaining": "a",
"crying": "a"
},
"inconsiderate": {
"bitching": "a",
"moaning": "a"
},
"categories": [
"a"
],
"id": 206
},
{
"type": "simple",
"considerate": {
"whine": "a",
"complain": "a",
"cry": "a"
},
"inconsiderate": {
"bitch": "a",
"moan": "a"
},
"categories": [
"a"
],
"id": 207
},
{
"type": "simple",
"considerate": {
Expand All @@ -3273,7 +3334,7 @@
"categories": [
"a"
],
"id": 204
"id": 208
},
{
"type": "simple",
Expand All @@ -3286,7 +3347,7 @@
"categories": [
"a"
],
"id": 205
"id": 209
},
{
"type": "simple",
Expand All @@ -3310,7 +3371,7 @@
"categories": [
"a"
],
"id": 206
"id": 210
},
{
"type": "simple",
Expand All @@ -3327,7 +3388,7 @@
"categories": [
"a"
],
"id": 207
"id": 211
},
{
"type": "simple",
Expand All @@ -3340,7 +3401,7 @@
"categories": [
"a"
],
"id": 208
"id": 212
},
{
"type": "simple",
Expand All @@ -3353,7 +3414,7 @@
"categories": [
"a"
],
"id": 209
"id": 213
},
{
"type": "simple",
Expand All @@ -3366,7 +3427,7 @@
"categories": [
"a"
],
"id": 210
"id": 214
},
{
"type": "simple",
Expand All @@ -3379,7 +3440,7 @@
"categories": [
"a"
],
"id": 211
"id": 215
},
{
"type": "simple",
Expand All @@ -3392,7 +3453,7 @@
"categories": [
"a"
],
"id": 212
"id": 216
},
{
"type": "simple",
Expand All @@ -3405,7 +3466,7 @@
"categories": [
"a"
],
"id": 213
"id": 217
},
{
"type": "simple",
Expand All @@ -3418,7 +3479,7 @@
"categories": [
"a"
],
"id": 214
"id": 218
},
{
"type": "simple",
Expand All @@ -3434,7 +3495,7 @@
"categories": [
"a"
],
"id": 215
"id": 219
},
{
"type": "and",
Expand All @@ -3454,6 +3515,6 @@
"a",
"b"
],
"id": 216
"id": 220
}
]
87 changes: 74 additions & 13 deletions retext-equality.js
Original file line number Diff line number Diff line change
Expand Up @@ -3842,6 +3842,67 @@ module.exports=[
],
"id": 203
},
{
"type": "simple",
"considerate": {
"staffed": "a",
"crewed": "a",
"pilotted": "a"
},
"inconsiderate": {
"manned": "a"
},
"categories": [
"a"
],
"id": 204
},
{
"type": "simple",
"considerate": {
"robotic": "a",
"automated": "a"
},
"inconsiderate": {
"unmanned": "a"
},
"categories": [
"a"
],
"id": 205
},
{
"type": "simple",
"considerate": {
"whining": "a",
"complaining": "a",
"crying": "a"
},
"inconsiderate": {
"bitching": "a",
"moaning": "a"
},
"categories": [
"a"
],
"id": 206
},
{
"type": "simple",
"considerate": {
"whine": "a",
"complain": "a",
"cry": "a"
},
"inconsiderate": {
"bitch": "a",
"moan": "a"
},
"categories": [
"a"
],
"id": 207
},
{
"type": "simple",
"considerate": {
Expand All @@ -3853,7 +3914,7 @@ module.exports=[
"categories": [
"a"
],
"id": 204
"id": 208
},
{
"type": "simple",
Expand All @@ -3866,7 +3927,7 @@ module.exports=[
"categories": [
"a"
],
"id": 205
"id": 209
},
{
"type": "simple",
Expand All @@ -3890,7 +3951,7 @@ module.exports=[
"categories": [
"a"
],
"id": 206
"id": 210
},
{
"type": "simple",
Expand All @@ -3907,7 +3968,7 @@ module.exports=[
"categories": [
"a"
],
"id": 207
"id": 211
},
{
"type": "simple",
Expand All @@ -3920,7 +3981,7 @@ module.exports=[
"categories": [
"a"
],
"id": 208
"id": 212
},
{
"type": "simple",
Expand All @@ -3933,7 +3994,7 @@ module.exports=[
"categories": [
"a"
],
"id": 209
"id": 213
},
{
"type": "simple",
Expand All @@ -3946,7 +4007,7 @@ module.exports=[
"categories": [
"a"
],
"id": 210
"id": 214
},
{
"type": "simple",
Expand All @@ -3959,7 +4020,7 @@ module.exports=[
"categories": [
"a"
],
"id": 211
"id": 215
},
{
"type": "simple",
Expand All @@ -3972,7 +4033,7 @@ module.exports=[
"categories": [
"a"
],
"id": 212
"id": 216
},
{
"type": "simple",
Expand All @@ -3985,7 +4046,7 @@ module.exports=[
"categories": [
"a"
],
"id": 213
"id": 217
},
{
"type": "simple",
Expand All @@ -3998,7 +4059,7 @@ module.exports=[
"categories": [
"a"
],
"id": 214
"id": 218
},
{
"type": "simple",
Expand All @@ -4014,7 +4075,7 @@ module.exports=[
"categories": [
"a"
],
"id": 215
"id": 219
},
{
"type": "and",
Expand All @@ -4034,7 +4095,7 @@ module.exports=[
"a",
"b"
],
"id": 216
"id": 220
}
]

Expand Down
2 changes: 1 addition & 1 deletion retext-equality.min.js

Large diffs are not rendered by default.

27 changes: 27 additions & 0 deletions script/gender.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1454,3 +1454,30 @@
inconsiderate:
manhour: male
man hour: male
- type: simple
considerate:
- staffed
- crewed
- pilotted
inconsiderate: manned
- type: simple
considerate:
- robotic
- automated
inconsiderate: unmanned
- type: simple
considerate:
- whining
- complaining
- crying
inconsiderate:
- bitching
- moaning
- type: simple
considerate:
- whine
- complain
- cry
inconsiderate:
- bitch
- moan
Loading

7 comments on commit ee7c95e

@danielhickman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitch is used as a noun as in:

John Smith is a bitch

I noticed it mentions the verb version, how should it handle the noun though?

@wooorm
Copy link
Member Author

@wooorm wooorm commented on ee7c95e Sep 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielhickman Well, bitch in that case is just a profanity. Profanities are beyond the scope of alex. alex checks for phrasing an author might mistakingly add without trying to offend; bitch as a noun is always added with the intent to offend.

@danielhickman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wooorm Ah okay, that makes sense.

@wooorm
Copy link
Member Author

@wooorm wooorm commented on ee7c95e Sep 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielhickman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to catch profanity too though, actually. I makes a lot of sense because of the slogan of Alex.

Catch insensitive, inconsiderate writing.

Alex wouldn't need to offer an alternative other than not to use it. Alex won't always be used by the author so it makes sense to catch even intentional offences. That's just my opinion though.

@wooorm
Copy link
Member Author

@wooorm wooorm commented on ee7c95e Sep 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielhickman Haven’t forgotten about this, thinking about whether or not to. 💭

@danielhickman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wooorm Okay great looking forward to it, if so.

Please sign in to comment.