Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use get_gstin_list function for fetching list of gstins in GSTR1 Report (backport #2593) #2597

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 5, 2024

  • default GSTIN was not fetched while setting GSTINs in GSTR-1 report (old)
  • Using the common utility to fetch GSTINs.

Frappe Support Issue: https://support.frappe.io/app/hd-ticket/21481

Huly®: IC-2712


This is an automatic backport of pull request #2593 done by Mergify.

@mergify mergify bot merged commit a797aaa into version-14-hotfix Sep 5, 2024
12 checks passed
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-2593 branch September 5, 2024 13:16
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.15%. Comparing base (da29fa2) to head (1492320).
Report is 14 commits behind head on version-14-hotfix.

Files with missing lines Patch % Lines
india_compliance/gst_india/report/gstr_1/gstr_1.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           version-14-hotfix    #2597   +/-   ##
==================================================
  Coverage              61.14%   61.15%           
==================================================
  Files                    114      114           
  Lines                  11057    11056    -1     
==================================================
  Hits                    6761     6761           
+ Misses                  4296     4295    -1     
Files with missing lines Coverage Δ
india_compliance/gst_india/report/gstr_1/gstr_1.py 38.27% <50.00%> (+0.05%) ⬆️

Impacted file tree graph

@india-compliance-bot
Copy link
Collaborator

🎉 This PR is included in version 14.30.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants