Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler libs uncurry ready #6861

Merged
merged 3 commits into from
Jul 7, 2024
Merged

Compiler libs uncurry ready #6861

merged 3 commits into from
Jul 7, 2024

Conversation

cristianoc
Copy link
Collaborator

Make compiler libs ready for uncurried mode.

Adapt cases of partial applications.
Following from #6764
Compile it in uncurried mode already, and make sure the output is identical.
@cristianoc cristianoc requested review from cknitt and zth July 7, 2024 08:16
@@ -1081,7 +1083,7 @@ function split_at_match_rec(_l$p, _x) {
case "TMatch" :
return [
List.rev(l$p),
Curry._1(remove_matches, x.tl)
remove_matches(x.tl)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting effect of not making List.filter implicitly curried. The use of Curry disappears even when compiled in curried mode.

Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cristianoc cristianoc merged commit 445bc51 into master Jul 7, 2024
19 checks passed
@cristianoc cristianoc deleted the compiler-libs-uncurry-ready branch July 7, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants