Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bs send pipe #6858

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Remove bs send pipe #6858

merged 3 commits into from
Jul 8, 2024

Conversation

cristianoc
Copy link
Collaborator

Following from Following from 8800a5e

@cristianoc cristianoc requested review from zth and bloodyowl July 5, 2024 08:27
@cknitt
Copy link
Member

cknitt commented Jul 6, 2024

Parts of Webapi.Dom and the whole Js_typed_array module are removed here. Don't we want to keep these for compatibility?

@cristianoc
Copy link
Collaborator Author

Parts of Webapi.Dom and the whole Js_typed_array module are removed here. Don't we want to keep these for compatibility?

I think it was discussed at the retreat that nobody uses js typed arrays. In fact, js array was also removed, but that seems more at risk of being used even if the bindings are old style.
The webapi stuff are just part of print tests, as part of larger files, and don't exercise any specific cases.

@cristianoc cristianoc requested a review from cknitt July 6, 2024 12:47
@cristianoc cristianoc enabled auto-merge (squash) July 7, 2024 16:25
@cristianoc cristianoc disabled auto-merge July 7, 2024 16:44
@cristianoc cristianoc enabled auto-merge (rebase) July 7, 2024 16:45
@cristianoc cristianoc merged commit 80764b1 into master Jul 8, 2024
18 checks passed
@cristianoc cristianoc deleted the remove-bs-send-pipe branch July 8, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants