Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive more field types for Arrow #739

Merged
merged 19 commits into from
Jan 13, 2023
Merged

Conversation

jondo2010
Copy link
Contributor

@jondo2010 jondo2010 commented Jan 12, 2023

This PR makes use of new features I built into arrow2_convert (upstream PR DataEngineeringLabs/arrow2-convert#90) and removes a bunch of boilerplate derives

Depends on #714

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@jondo2010 jondo2010 merged commit 7030d0f into main Jan 13, 2023
@jondo2010 jondo2010 deleted the john/derive_more_field_types branch January 13, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants