Skip to content

Commit

Permalink
Fix rebase + clean code
Browse files Browse the repository at this point in the history
  • Loading branch information
abey79 committed Oct 12, 2023
1 parent 54efcd1 commit a7bf17d
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 16 deletions.
20 changes: 9 additions & 11 deletions crates/re_data_store/src/store_db.rs
Original file line number Diff line number Diff line change
Expand Up @@ -245,17 +245,15 @@ impl StoreDb {
store_info: StoreInfo,
rows: impl IntoIterator<Item = DataRow>,
) -> anyhow::Result<Self> {
let arrow_msg = DataTable::from_rows(TableId::random(), rows).to_arrow_msg()?;
let store_id = store_info.store_id.clone();
let mut store_db = StoreDb::new(store_id.clone());
store_db.add(
&SetStoreInfo {
row_id: RowId::random(),
info: store_info,
}
.into(),
)?;
store_db.add(&LogMsg::ArrowMsg(store_id, arrow_msg))?;
let mut store_db = StoreDb::new(store_info.store_id.clone());

store_db.set_store_info(SetStoreInfo {
row_id: RowId::random(),
info: store_info,
});
for row in rows {
store_db.add_data_row(&row)?;
}

Ok(store_db)
}
Expand Down
2 changes: 1 addition & 1 deletion crates/re_viewer/data/quick_start_guides/cpp_native.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
## C++ Quick Start

TODO(ab)
TODO(ab)
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
### How does it work?

TBC
TBC
2 changes: 1 addition & 1 deletion crates/re_viewer/data/quick_start_guides/python_native.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ rr.log(
# log data as a 3D point cloud archetype
rr.Points3D(positions, colors=colors, radii=0.5)
)
```
```
2 changes: 1 addition & 1 deletion crates/re_viewer/data/quick_start_guides/rust_native.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
## Rust Quick Start

TODO(ab)
TODO(ab)
2 changes: 1 addition & 1 deletion crates/re_viewer/src/ui/welcome_screen/welcome_page.rs
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ fn open_quick_start<'a>(
entity_path: impl AsRef<str>,
) {
let markdown = parts.into_iter().join("\n");
let res = open_markdown_recording(command_sender, &markdown, app_id, entity_path);
let res = open_markdown_recording(command_sender, markdown, app_id, entity_path);
if let Err(err) = res {
re_log::error!("Failed to load quick start: {}", err);
}
Expand Down

0 comments on commit a7bf17d

Please sign in to comment.