Skip to content

Commit

Permalink
fix: breaking change in tough-cookie v3
Browse files Browse the repository at this point in the history
  • Loading branch information
@analog-nico
analog-nico committed Feb 14, 2019
1 parent 14aa6ee commit 4633d4c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
},
"dependencies": {
"request-promise-core": "1.1.1",
"stealthy-require": "^1.1.0",
"tough-cookie": ">=2.3.3"
"stealthy-require": "^1.1.1",
"tough-cookie": "~2.3.3"

This comment has been minimized.

Sign in to view

Copy link
@evocateur

evocateur Feb 15, 2019

Shouldn't this have been a ^2.3.3 range? It's now nesting a same-major duplicate under jsdom, for example:
image

This comment has been minimized.

Sign in to view

Copy link
@analog-nico

analog-nico Feb 15, 2019

Author Member

The version number has to be identical with the one that request is using. That’s actually why request-promise-native is having tough-cookie as a dependency in the first place. So request-promise-native is as lenient with the version number as request is.

If you reinstall you can avoid this duplicate as part of jsdomas well.

This comment has been minimized.

Sign in to view

Copy link
@evocateur

evocateur Feb 15, 2019 

$ npm show request dependencies.tough-cookie
~2.4.3

This comment has been minimized.

Sign in to view

Copy link
@analog-nico

analog-nico Feb 15, 2019

Author Member

Sounds good! Using ~2.3.3 is for backwards compatibility for older versions of request.

This comment has been minimized.

Sign in to view

Copy link
@evocateur

evocateur via email Feb 15, 2019

This comment has been minimized.

Sign in to view

Copy link
@analog-nico

analog-nico Feb 15, 2019

Author Member

Oh, darn it. I mixed up ^ and ~. Thanks a ton! I’ll change it.
},
"peerDependencies": {
"request": "^2.34"
Expand Down

0 comments on commit 4633d4c

Please sign in to comment.