Import IObjectEvent from zope.interface.interfaces #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nent.interfaces, as zope.component 5.0 (latest release) removed IObjectEvent and some other deprecated interfaces.
|
It seems the checks on TravisCI failed because it is not able to run the given python interpreters: Tests passed correctly locally here with python 3.7, 3.8 and 3.9, code worked fine in a testing deploy of a bigger pyramid app using it (also 3.7, 3.8 and 3.9). |
This lets us install this directly from the repo with a link in setup.py, in packages that depend on repoze.folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zope.component 5.0 (latest release) removed IObjectEvent and some other deprecated interfaces, more info here: zopefoundation/zope.component#59
This little change ensures repoze.folder keeps working with recent zope.component releases.
(and those deprecated interfaces have been in the zope.interface package for a while anyway)
Regards.