Implemented new feature: display last error log in scenario description #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vrymar
commented
Mar 4, 2024
vrymar
commented
- Implemented new feature: display last error log in scenario description
- Implemented unit tests for the new feature
- Improved dependencies references in build.gradle
Implemented unit tests for the new feature Improved dependencies references in build.gradle
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24 +/- ##
=============================================
+ Coverage 89.10% 89.71% +0.60%
- Complexity 128 131 +3
=============================================
Files 4 4
Lines 413 418 +5
Branches 37 35 -2
=============================================
+ Hits 368 375 +7
Misses 26 26
+ Partials 19 17 -2 ☔ View full report in Codecov by Sentry. |
…log-to-scenario-description # Conflicts: # build.gradle
…log-to-scenario-description # Conflicts: # src/main/java/com/epam/reportportal/karate/ReportPortalHook.java
|
@HardNorth could you please review this PR? |
|
@vrymar Sure, will do this tomorrow. |
HardNorth
requested changes
Mar 6, 2024
CHANGELOG.md
Outdated
| @@ -4,6 +4,13 @@ | |||
| ### Removed | |||
| - Shutdown hook register on supplied Launch, by @HardNorth | |||
|
|
|||
| ## [5.0.4] | |||
There was a problem hiding this comment.
Please don't add version tag, it is added automatically.
There was a problem hiding this comment.
HardNorth
requested changes
Mar 6, 2024
CHANGELOG.md
Outdated
Comment on lines
4
to
5
| ### Removed | ||
| - Shutdown hook register on supplied Launch, by @HardNorth |
There was a problem hiding this comment.
Please don't revert my changes.
HardNorth
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.